8000 removeing xrd folder. by RubelMozumder · Pull Request #287 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

removeing xrd folder. #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2024
Merged

removeing xrd folder. #287

merged 2 commits into from
Mar 19, 2024

Conversation

RubelMozumder
Copy link
Collaborator
@RubelMozumder RubelMozumder commented Mar 19, 2024 •
edited
Loading
  • Remove XRD reader dif
  • update tests, and test data

This PR spatially satisfies of issue #283 .

@coveralls
Copy link
coveralls commented Mar 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8339734009

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.7%) to 48.099%
Files with Coverage Reduction New Missed Lines %
pynxtools/nexus/nxdl_utils.py 1 73.49%
pynxtools/dataconverter/template.py 2 83.74%
pynxtools/dataconverter/helpers.py 2 91.14%
Totals Coverage Status
Change from base Build 8294211401: -1.7%
Covered Lines: 3201
Relevant Lines: 6655
💛 - Coveralls

@RubelMozumder RubelMozumder requested a review from domna March 19, 2024 08:27
domna
domna approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubelMozumder RubelMozumder merged commit 088cb4a into master Mar 19, 2024
@RubelMozumder RubelMozumder deleted the remove_XRD branch March 20, 2024 10:04
mkuehbach pushed a commit that referenced this pull request Mar 21, 2024
@RubelMozumder @atomprobe-tc
removeing xrd folder. (#287)
431352e 
* removeing xrd folder.

* Removing XRD test files.
RubelMozumder added a commit that referenced this pull request Mar 26, 2024
@RubelMozumder
removeing xrd folder. (#287)
8fcf1d6 
* removeing xrd folder.

* Removing XRD test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubelMozumder @coveralls @domna
0