Transmission reader #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e216c0d to
14073f7
Compare
sanbrock
reviewed
Aug 10, 2022
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Skeleton for transmission parser * Adds reading functionality to transmission reader * Updates transmission reader to write valid file for example * Adds metadata parsing from asc file for transmission reader * Adds more transmission metadata parsers and example data * Updates action to install exactly astroid 2.5.1 * Fixes pylinting and tests * Correctly imports Mapping * Adds docstrings to transmission reader * Corrections in how to write a reader readme * Adds reading of detector values to transmission reader * Uses pre-set min/max wavelengths in transmission parser * Updates nexus_definitions submodule * Use the same pandas version as nomad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reader parser Perkin Ellmer measurement files (.asc) into the new NXtransmission appdef.
There are also some changes to the How to write a Reader readme file, because it was outdated.
I also made a change to the templates update function to be able to update the template with a standard python dict.