8000 Adding XRD plugin by RubelMozumder · Pull Request #296 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding XRD plugin #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 27, 2024
Merged

Adding XRD plugin #296

merged 5 commits into from
Mar 27, 2024

Conversation

RubelMozumder
Copy link
Collaborator
@RubelMozumder RubelMozumder commented Mar 26, 2024 •
edited
Loading

Remove APM and EM from the plugin list

@coveralls
Copy link
coveralls commented Mar 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8450732411

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 77.738%
Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.77%
Totals Coverage Status
Change from base Build 8436935616: -0.03%
Covered Lines: 2598
Relevant Lines: 3342
💛 - Coveralls

@RubelMozumder RubelMozumder changed the title Comparison Purpose Adding XRD plugin Mar 27, 2024
@RubelMozumder RubelMozumder requested a review from sanbrock March 27, 2024 11:07
@RubelMozumder RubelMozumder marked this pull request as ready for review March 27, 2024 11:07
sanbrock
sanbrock approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 5014593 into master Mar 27, 2024
@sanbrock sanbrock deleted the XRDuseCase branch March 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubelMozumder @coveralls @sanbrock
0