8000 Update manifest file by domna · Pull Request #299 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update manifest file #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

Update manifest file #299

merged 1 commit into from
Mar 27, 2024

Conversation

domna
Copy link
Collaborator
@domna domna commented Mar 27, 2024

As @fekad pointed out we include docs and tests directory in our wheel file. This should not be the case.

This PR updates the MANIFEST.in file to explicitly include only the correct folder and files.

@domna domna 8000 requested a review from sherjeelshabih March 27, 2024 13:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8452560540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 77.768%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 1 74.86%
pynxtools/nexus/nxdl_utils.py 2 73.07%
pynxtools/dataconverter/helpers.py 2 90.68%
Totals Coverage Status
Change from base Build 8450849041: 0.0%
Covered Lines: 2599
Relevant Lines: 3342
💛 - Coveralls

1 similar comment
@coveralls
Copy link
coveralls commented Mar 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8452560540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 77.768%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 1 74.86%
pynxtools/nexus/nxdl_utils.py 2 73.07%
pynxtools/dataconverter/helpers.py 2 90.68%
Totals Coverage Status
Change from base Build 8450849041: 0.0%
Covered Lines: 2599
Relevant Lines: 3342
💛 - Coveralls

@lukaspie lukaspie self-requested a review March 27, 2024 16:15
lukaspie
lukaspie approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator
@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domna domna merged commit 503ccf6 into master Mar 27, 2024
@domna domna deleted the update-manifest branch March 27, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

@sherjeelshabih sherjeelshabih Awaiting requested review from sherjeelshabih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domna @coveralls @lukaspie
0