8000 Fixes enumeration check by domna · Pull Request #313 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes enumeration check #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 18, 2024
Merged

Fixes enumeration check #313

merged 12 commits into from
Apr 18, 2024

Conversation

domna
Copy link
Collaborator
@domna domna commented Apr 18, 2024

No description provided.

@domna domna requested a review from rettigl April 18, 2024 08:44
@domna domna self-assigned this Apr 18, 2024
@domna domna mentioned this pull request Apr 18, 2024
Merged
@coveralls
Copy link
coveralls commented Apr 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8734997514

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 87 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.009%) to 77.883%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 1 74.86%
pynxtools/dataconverter/helpers.py 2 90.32%
pynxtools/definitions/dev_tools/utils/nxdl_utils.py 84 74.18%
Totals Coverage Status
Change from base Build 8703588887: 0.009%
Covered Lines: 2620
Relevant Lines: 3364
💛 - Coveralls

@coveralls
Copy link
coveralls commented Apr 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8741416728

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 91 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 77.91%
Files with Coverage Reduction New Missed Lines %
pynxtools/definitions/dev_tools/utils/nxdl_utils.py 91 74.44%
Totals Coverage Status
Change from base Build 8735652190: 0.05%
Covered Lines: 2624
Relevant Lines: 3368
💛 - Coveralls

sanbrock
sanbrock reviewed Apr 18, 2024
View reviewed changes
sanbrock
sanbrock requested changes Apr 18, 2024
View reviewed changes
sanbrock
sanbrock approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domna
Copy link
Collaborator Author
domna commented Apr 18, 2024

@sanbrock could you also review FAIRmat-NFDI/nexus_definitions#218

I would merge this first and after this update the definitions to the fairmat branch here before I merge.

@domna domna merged commit df8001b into master Apr 18, 2024
@domna domna deleted the fix-enumeration-check branch April 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

@rettigl rettigl Awaiting requested review from rettigl

Assignees

@domna domna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domna @coveralls @sanbrock
0