8000 deprecation of ellipsometry reader in favor of its own pynxtools-ellips plugin by RonHildebrandt · Pull Request #322 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

deprecation of ellipsometry reader in favor of its own pynxtools-ellips plugin #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024

Conversation

RonHildebrandt
Copy link
Contributor

Removed the files related to the ellips reader from examples and readme files etc.

This is done to prepare setting up an individual github repository for the pynxtools-ellips plugin.

@RonHildebrandt RonHildebrandt requested a review from mkuehbach May 3, 2024 06:27
@coveralls
Copy link
coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8936048350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.3%) to 81.088%

Files with Coverage Reduction New Missed Lines %
pynxtools/definitions/dev_tools/utils/nxdl_utils.py 1 74.23%
tests/dataconverter/test_readers.py 1 91.07%
pynxtools/dataconverter/template.py 3 83.72%
Totals Coverage Status
Change from base Build 8892375619: 2.3%
Covered Lines: 2564
Relevant Lines: 3162

💛 - Coveralls

add @lukaspie  suggestions.
@RonHildebrandt RonHildebrandt requested a review from lukaspie May 3, 2024 08:42
Copy link
Collaborator
@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0