8000 the line number of the yaml file is displayed in the error message by andreaa93 · Pull Request #34 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

the line number of the yaml file is displayed in the error message #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 7, 2022
Merged

the line number of the yaml file is displayed in the error message #34

merged 10 commits into from
Sep 7, 2022

Conversation

andreaa93
Copy link
Collaborator

No description provided.

@andreaa93
Copy link
Collaborator Author
andreaa93 commented Sep 5, 2022 •
edited
Loading

I also added the support to "extends" in the yaml file, as asked by @domna

Note that I also changed the file used for testing:
/nomad/dependencies/parsers/nexus/tests/data/tools/dataconverter/readers/mpes/Ref_nexus_mpes.log

Because some field was changed in the nxdl from optional to recommended or required.

@andreaa93 andreaa93 requested a review from domna September 5, 2022 13:12
domna
domna approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extends keyword works like a charm. Did not review anything else.

The Ref log output for mpes should be the same as in the main branch now, because I updated it only yesterday.

@andreaa93
Copy link
Collaborator Author

Ok nice, so we will confirm this when merging

sanbrock
sanbrock requested changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to have some test cases where the new feature is checked

sherjeelshabih
sherjeelshabih reviewed Sep 7, 2022
View reviewed changes
sherjeelshabih
sherjeelshabih requested changes Sep 7, 2022
View reviewed changes
@andreaa93 andreaa93 requested a review from sanbrock September 7, 2022 15:02
@sanbrock sanbrock merged commit 8c2a839 into master Sep 7, 2022
@sanbrock sanbrock deleted the fileline_handling branch September 7, 2022 15:53
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
@andreaa93
the line number of the yaml file is displayed in the error message (#34)
72a394c 
* lineloader class

* Line Tags in Error Messages!

* pylint

* support extends keyword in root level of yaml file

* cleaning yaml2nxdl folder

* pylint

* tests implemented and PR comments solved

* test_yaml2nxdl updated

* test yaml2nxdl failing

* python version changed in pylint.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@sherjeelshabih sherjeelshabih sherjeelshabih approved these changes

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreaa93 @domna @sherjeelshabih @sanbrock
0