place fsh-index.json in the data folder #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, @costateixeira! I tested it manually (in addition to the unit tests) and it works as expected. I also checked to see if we document this in FSH School, and I don't think we do, so I don't think there is any need to update documentation. That said, could you please edit this PR's description to describe the changes you made and why you made them? Please also include a link to [this zulip thread](#ig publishing requirements > sushi index file location @ 💬) in the description so it's clear that we discussed this in the community. Thanks for contributing this! |
|
@cmoesel can you please see if it is ok? |
|
Perfect. Thank you! |
cmoesel
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR puts the fsh-index.json not in fsh-generated but in fsh-generated/data. This way, it is possible to allow the IG Publisher to consider this an additional data folder, and use this in rendering. This was originally requested and discussed in Zulip here:#ig publishing requirements > sushi index file location @ 💬
Testing Instructions:
When running sushi, the fsh-index.json should be in fsh-generated/data