Fix bug detecting dependency uri when wildcard patch is used #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix matching against IGs when a .x version is used in the dependency list. This resolves the version based on the IGs in scope.
|
Merging this based on @jduteau's review and approval which was communicated to me via another channel. Unfortunately, GitHub is mysteriously preventing him from formally reviewing it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix IG JSON generation code to properly match .x versioned dependencies to their official URIs. This resolves the actual version based on the dependency IGs in scope.
This issue was raised on Zulip at #shorthand > ✔ us-core uri @ 💬.
Testing Instructions:
Create a SUSHI project with the following dependency:
Run the currently released version of SUSHI against the project and note that the generated IG JSON lists the US Core URI as
http://fhir.org/packages/hl7.fhir.us.core/ImplementationGuide/hl7.fhir.us.core, which is wrong.Now pull down this branch of SUSHI and run
npm install, then runts-node src/app.ts build /path/to/that_same_fsh_project. The generated IG JSON should list the US Core URI ashttp://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core.Related Issue: Fixes #1563