srv6: Introduce IPv6 address in segment-list used by TE Policy #15057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f63bf8 to
fccc0c2
Compare
|
Fix warnings by checkpatch. |
4d285ff to
331f8d4
Compare
|
2 small fixes for isis_sr_te uploaded in the recent push. |
331f8d4 to
57fdef4
Compare
ton31337
reviewed
Jan 6, 2024
| @@ -0,0 +1,35 @@ | |||
| password 1 | |||
| create_interface_in_kernel, | ||
| ) | ||
|
|
||
| pytestmark = [pytest.mark.isisd, pytest.mark.sharpd] |
There was a problem hiding this comment.
Shouldn't bgpd, pathd be included also?
There was a problem hiding this comment.
really fixed by also adding the
pytest.mark.pathd
riw777
reviewed
Jan 16, 2024
lib/zclient.c
Outdated
|
|
||
| stream_putw(s, zt->srv6_segs.num_segs); | ||
|
|
||
| stream_put(s, &zt->srv6_segs.segs[0], |
There was a problem hiding this comment.
yes ... this should check for an empty seg before putting, I think
donaldsharp
reviewed
Jan 16, 2024
donaldsharp
reviewed
Jan 16, 2024
lib/srte.h
Outdated
| ZEBRA_SR_SRV6_SRTE = 2, /* SRv6 SID List*/ | ||
| }; | ||
|
|
||
| static inline enum lsp_types_t lsp_type_from_sr_type(int sr_type) |
There was a problem hiding this comment.
Shouldn't this pass in a enum sr_types.. instead of an int? Let's let the compiler help us please
There was a problem hiding this comment.
Please remove the default case here.
donaldsharp
reviewed
Jan 16, 2024
donaldsharp
reviewed
Jan 16, 2024
donaldsharp
reviewed
Jan 16, 2024
zebra/rt_netlink.c
Outdated
| @@ -1550,7 +1550,7 @@ static ssize_t fill_seg6ipt_encap(char *buffer, size_t buflen, | |||
| srh->first_segment = segs->num_segs - 1; | |||
|
|
|||
| for (i = 0; i < segs->num_segs; i++) { | |||
| memcpy(&srh->segments[i], &segs->seg[i], | |||
| memcpy(&srh->segments[segs->num_segs - i - 1], &segs->seg[i], | |||
There was a problem hiding this comment.
This is only 1/2 of the equation, we need to fix the decode side as well. Add the ipv6 seg6 route from the linux cli and the segments are backwards in comparison.
There was a problem hiding this comment.
Thanks, fixed,
donaldsharp
requested changes
Jan 16, 2024
zebra/zebra_srte.c
Outdated
|
|
||
| for (rn = route_top(table); rn; rn = route_next(rn)) { | ||
| RNODE_FOREACH_RE_SAFE (rn, re, next) { | ||
| if (re->nhe->nhg.nexthop->srte_color == |
There was a problem hiding this comment.
invert this logic so the indent is not so deep this is hard to read
zebra/zebra_srte.c
Outdated
| @@ -133,6 +136,47 @@ static int zebra_sr_policy_notify_update_client(struct zebra_sr_policy *policy, | |||
| } | |||
| stream_putl(s, policy->color); | |||
|
|
|||
| if (policy->segment_list.srv6_segs.num_segs > 0) { | |||
| /* Lookup table. */ | |||
| table = zebra_vrf_table(AFI_IP6, SAFI_UNICAST, VRF_DEFAULT); | |||
There was a problem hiding this comment.
What is supposed to happen when we have > 1 million routes? What is a reasonable number of items that are going to be sent. Are we going to run out of packet space? Are we going to just cpuhog like you would not believe?
|
Thank you very much for your reviews, @ton31337, @riw777, @donaldsharp. I was on PTO, thus the response delay. I expect to look at this PR in coming time. @cscarpitta, WDYT about the cli format for ipv6 address? Does it look good? |
c0b8fb3 to
8f81927
Compare
bc7bd02 to
2e23a77
Compare
912c01b to
5d11272
Compare
|
ci:rerun |
ab4d99b to
d755e07
Compare
|
I fixed this PR, now CI passes: @donaldsharp, @riw777 , @ton31337, Could you please take a look one more time? |
riw777
approved these changes
Apr 8, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Add SRv6 segments to zapi_srte_stunnel structure. Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
d755e07 to
70f78f6
Compare
70f78f6 to
a491c17
Compare
Add SRv6 SID value (srv6-sid-value) to the YANG model. Implement nb handlers for this new value. Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
Add structute sr_types_t, that contains the Segment Routing types. Fill the zapi_sr_policy's segment_list with values such as: - value - local_label - num_segs - srv6_segs Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
SR-TE tunnel must contain at least one label or SRv6 SID. Check this condition. Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
When the segment list is not empty add SRv6 segments to a nexthop. Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
Encode and Decode SRv6-TE. It includes: - number of segments - list of segments Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
When configuring an SRv6 SID list via iproute2, the segment list that appears in vtysh, learned from the kernel, is inversed. Fix the order of SRv6 SIDs in segment list, learned from the kernel. Fixes: f20cf14 ("bgpd,lib,sharpd,zebra: srv6 introduce multiple segs/SIDs in nexthop") Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
Pathd needs to track the reachability of the first SID of any SRv6 segment-list. Use the nexthop tracking facility and add the pathd daemon as a client to nht service from zebra. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
The Pathd daemon is aware of the SID reachability, but still once the sr policy installed in zebra, there is need to re-resolve the SID reachability. Extend the Pathd NHT service, by extracting the resolved next-hop. This information will be conveyed in the SR_POLICY_SET message, and will be very helpful to simplify code in zebra. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
When SRv6 list of segments was changed, change SRv6 policy. Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
FAFE
…nt_list When notifying an update for a colored nexthop, ZEBRA sends the default PATHD distance value and the 0 metric value. Those two values break the original values that originated from an IGP route, for instance. When transmitting this information to BGP for instance, the distance and values are very important when computing BGP paths. Change this by keeping the original distance and metric values. When SRv6 segment list size is bigger than 0, send segments and other elements via zserv_send_message(). The ZEBRA SRTE code can not rely on the routing table. Use instead the resolved nexthop information gathered by th SRv6 SRTE information. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
Consider an srv6 policy active, when sr policy set is received. The sr_policy_validate() function is however called, the default state value is down, and immediately sent to UP. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
Add pathd srv6 segment list support. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Dmytro Shytyi <dmytro.shytyi@6wind.com>
SRv6 Policy is an ordered list of segments that represent a source-routed policy. Packet flows are steered into an SRv6 Policy. Signed-off-by: Dmytro Shytyi <dmytro@shytyi@6wind.com> Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
a491c17 to
a6d47aa
Compare
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These series of patches introduce new feature: user may configure ipv6-address in segment list.
Format:
Example:
Signed-off-by: Dmytro Shytyi dmytro.shytyi@6wind.com