Add number to fontWeight union
#81
Conversation
|
Hi @nezort11 ! Thank you for contributing. This is a great find, however we should fix this for all components instead of just for To fix this we should add a line like: if (mjmlAttributeType === "number") {
return "string | number"
}inside of the |
|
It looks like mjml defines font-weight as a string: https://github.com/mjmlio/mjml/blob/85bc58e9e2a88cef7424dc2fce3d889f66fb4298/packages/mjml-text/src/index.js#L18 We typically want to stick with the mjml types but it seems that it's not enforced with their strict validation: https://mjml.io/try-it-live/dKaQw9yEj Not positive what to do here yet. |
In the previous version enum was being pre-empted by CSSProperties. This resulted in some values not passing type checking when using validationLevel: "strict". Fixes #81
fontWeightcan be anumber(e.g.700,400).like