10000 add `aec_wrapper_fn` by Kallinteris-Andreas · Pull Request #879 · Farama-Foundation/PettingZoo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add aec_wrapper_fn #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

add aec_wrapper_fn #879

merged 1 commit into from
Mar 6, 2023

Conversation

Kallinteris-Andreas
Copy link
Contributor

Description

added aec_wrapper_fn the opposite of parallel_wrapper_fn

was originally used in Gymnasium-Robotics/MaMuJoCo (https://github.com/Farama-Foundation/Gymnasium-Robotics/blob/main/gymnasium_robotics/envs/multiagent_mujoco/mujoco_multi.py#L548)

I have not written any unit tests (not sure what is there to test anyway)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

jjshoots
jjshoots approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member
@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PZ seems to have a lot of redundant wrappers but otherwise, seems reasonable to me.

@jjshoots jjshoots merged commit d225feb into Farama-Foundation:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjshoots jjshoots jjshoots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kallinteris-Andreas @jjshoots
0