Update to embedded-hal 1.0.0 #24
Conversation
As of 11.10.2023 probe-run is in maintainance mode. They recommend everyone to switch to probe-rs.
Feats: - update emvedded-hal to 1.0.0 - update dispaly-interface to 0.5.0 - update the examples accordigly - added embedded-hal-bus to handle spi connection Note on examples: - Removed with_shared_bus example since version 0.5.0 of display-interface-spi encourages the use of embedded-hal-bus, which takes care of the bus sharing. - I don't really like that creating an SpiDevice requires passing a Timer, further inspection is required.
|
You can go ahead and bump the version :) |
|
I'm not sure we need waiting anywhere in the transfer, maybe In an actual proper project this would not matter, almost all monotonics in RTIC are shareable between peripherals. So this would not utilize a second timer. |
examples/nrf52840_dogm132w5_graphics.rs
Outdated
Show resolved
Hide resolved
|
Thank you! I've applied the changes, it should be ready to merge now |
|
Min rust version got changed with |
|
Oops, I didn't catch that. Updated it |
|
You did not test the examples yet, right? |
Unfortunately I have an nrf board here, but I forgot my jlink at home so I can only test it in a few weeks. They do compile fine tho, and practically the same code (apart from the spi_bus initialization) works with my esp32c3. |
|
Works on my board. |
|
Missing: Doc updates (Readme.md) |
|
I've fixed the README code and did some minor beautifications in the examples, are you alright with my changes? |
Feats:
Note on examples:
encourages the use of embedded-hal-bus, which takes care of the bus sharing.
inspection is required.
I didn't manage to test the examples with an nrf board, but I tested the changes on my esp-32c3 board using
esp-hal.Since the update requires the users to update to a new embedded_hal version, I think the version should be updated accordingly (i.e. bumping this crate to 0.6.0).