Added limit to the message box size (#55) #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mostly dislike the limit of 5. Could it be possible to increase this limit (to 15 ?) or be able to set it in settings (in order to fit phone sizes and users preferences) ? A limit of 5 is not quite useful with very long message and a large message box while writing a long message is part of the reasons why I use the app. |
|
I agree, let's bump it to 8 or 10 lines. We'll consider a preference if it is requested by many users. |
|
Great, thanks :) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull reques
2C2D
t is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Added limit of 5 lines to the message box size. It's the same limit as in OnePlus stock SMS app and Signal.
Before/After Screenshots/Screen Record
qemu-system-x86_64_sOjUfihEBs.mp4
qemu-system-x86_64_TwMtWHisjZ.mp4
Fixes the following issue(s)
Acknowledgement