Trestle refactor #26
Merged
Trestle refactor #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGallicchio
commented
Jan 17, 2025
| @@ -75,11 +78,49 @@ lemma mem_vars_of_flip {φ : PropForm ν} {τ : PropAssignment ν} (x : ν) : τ | |||
| simp_all only [vars, satisfies_var, Finset.mem_singleton] | |||
| by_contra h | |||
| exact hτ' (hτ ▸ τ.set_get_of_ne (!τ x) h) | |||
| | _ => | |||
| simp_all only | |||
| [satisfies_conj, satisfies_disj, satisfies_impl', satisfies_biImpl', vars, Finset.mem_union] | |||
There was a problem hiding this comment.
I know the simp_all proof is slow, but it is likely more robust to change, and easier to maintain. tradeoff worth considering.
| @@ -50,18 +51,22 @@ section subst | |||
|
|
|||
| variable (f f₁ : ν₁ → PropForm ν₂) (f₂ : ν₂ → PropForm ν₃) (φ φ₁ φ₂ : PropForm ν₁) | |||
|
|
|||
| -- CC: Unnecessary block of theorems, if the definition is `reducible` anyways? | |||
There was a problem hiding this comment.
Unless simp has changed recently, you can have definitional equations like this where the LHS is simp-normal (ie you need to add it as a simp lemma). I don't remember how to determine when it is/isn't necessary though
There was a problem hiding this comment.
oh i see what you mean
still no clue if the simps are necessary or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.