-
Notifications
You must be signed in to change notification settings - Fork 1
Add new core logic system #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension is automatically loaded when starting vscode.
The logic compiler tool is a separate tool that reads all files written in the ".w5logic" format and generates C# code the represents that. The generated code is a module similar to the previous theme extensions and provide game modes, character roles and more that can be used to extend the server.
Doing this makes the creation of new game modes simpler and less confusing
The game mode is now implemented using the new logic design.
6cb165b
to
f4392cf
Compare
I want to have this finished. The tests seem to be working and trying this locally doesn't result in any errors. Also is the todo list finally empty. If it happens that this PR introduced some errors, just create an issue and it will be fixed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large update and contains many things that needed to be updated. The main goal of this PR was, to introduce a custom language in which are all game modes written and have the core logic simplified.
The custom language was named
w5logic
and was designed without looking at the current server code but trying to get the necessary and wished features done. Everything should be expressed in as little code as possible and with several automatic checks that can be done at compile time.The migration of the old logic code was relatively easy but the core system needed some adjustments and new features that weren't supported before (e.g. sequences). Also are some things renamed (e.g. "roles" into "character") to express their usage better.
And after all are some basic maintenance done like dependency version bumps (e.g from dotnet 6.0 to 8.0) and the introduction of CI.
Close: #29