Update vignettes #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdz2101
reviewed
Mar 12, 2025
| - `Flag_Poisson()`: Default flagging function when `Analyze_Poisson()` is used for an assessment | ||
| - `Flag()`: Default flagging function when `Analyze_Identity()` is used for an assessment | ||
| - `Flag()`: Default flagging function for all assessments | ||
| - `Flag_NormalApprox()`: Deprecated flagging function when `Analyze_NormalApprox()` is used for an assessment. |
There was a problem hiding this comment.
Because gsm.core itself is starting out off the jump with just Flag() is it better to just remove any mentions of previously deprecated things?
There was a problem hiding this comment.
hmmm, i suppose i wanted to keep this in there in case people were working with older workflows they have saved locally. might cut it once we get farther down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update vignettes. Mostly copied over edits from gsm PR #2042. Also updated the README and description
Note: The cookbook, contributor guidelines, Data Model and gsm Extensions will likely live in
{openrbqm}and theopenRBQMwebsite, but I wanted them to have a home in the meantime so that people can still have all the documentation they need.Test Notes/Sample Code
Connected Issues