Closes #5 and #6 update yamls as requested #19
Conversation
Merge branch 'dev' into fix-5_6 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'dev' into fix-5_6
| @@ -30,7 +31,7 @@ Imports: | |||
| yaml | |||
| Remotes: | |||
| clindata=Gilead-BioStats/clindata, | |||
| gsm=Gilead-BioStats/gsm@fix-2010 | |||
| gsm=Gilead-BioStats/gsm@zz_test | |||
There was a problem hiding this comment.
Make the appropriate swap to a branch that contains the stop_if() export, I had a branch called zz_test that contained it but it looks like the v2.2.2 candidate will too, if that Gilead-BioStats/gsm#2021, gets merged point this gsm=Gilead-BioStats/gsm@{INSERT BRANCH} (probably dev or main?) into here
There was a problem hiding this comment.
would we want to wait until the PR that resolves 2010 to be merged into dev to make this change? otherwise we are using the version of gsm that has all of the duplicate functions as gsm.mapping
There was a problem hiding this comment.
I think that containing the duplicates for now should be fine, you can solve for NAMESPACE gaps in gsm after the fact (make sure all gsm.mapping functions in tests/vignettes call gsm.mapping:: ), the trick scenario is when a branch of gsm has this branch as a suggests and this branch points directly back at the aforementioned gsm branch, I had it set up like this but the ci/cd would be on the fritz quite frequently, sometimes working sometimes not
There was a problem hiding this comment.
@lauramaxwell added a readme blurb as well as instructions across the cookie trail of PRs I have up related to the splitting. In terms of steps:
- Merge Closes #2010 migration of additional mapping aspects gsm#2018 and v2.2.2 RC gsm#2021
- Change the
DESCRIPTIONfile of this branch/PR to have a dependency ongsmthat contains thestop_if()export - Merge this PR
- Modify the
.githubworkflows of Closes #1972 intial gsm.mapping spin out gsm#2002 toinstall_github("Gilead-BioStats/gsm.mapping", ref = "dev") - Whenver we're ready to merge that, the two packages should "successfully" fingers crossed separated
Co-authored-by: Laura Maxwell <laura.maxwell1@gilead.com>
Co-authored-by: Laura Maxwell <laura.maxwell1@gilead.com>
Co-authored-by: Laura Maxwell <laura.maxwell1@gilead.com>
DESCRIPTION/ readme