Allow Study (QTL), Site (KRI) and custom groupings #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samussiah
reviewed
Jul 13, 2022
| @@ -105,7 +106,7 @@ AE_Assess <- function( | |||
|
|
|||
| lAssess$dfTransformed <- gsm::Transform_EventCount( | |||
| lAssess$dfInput, | |||
| strGroupCol = strGroupCol, | |||
| strGroupCol = paste0(strGroupCol,"ID"), | |||
There was a problem hiding this comment.
Assumption here that the grouping variable will always be suffixed with ID - why not explicitly specify the column name?
samussiah
reviewed
Jul 13, 2022
| GroupID = lMapping[["dfSUBJ"]][["strGroupCol"]], | ||
| SiteID = lMapping[["dfSUBJ"]][["strSiteCol"]], | ||
| StudyID = lMapping[["dfSUBJ"]][["strStudyCol"]], | ||
| CustomGroupID = lMapping[["dfSUBJ"]][["strCustomGroupCol"]], |
There was a problem hiding this comment.
Now I get it - site/study/custom columns are named here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Rough sketch of how we might allow Study/Site/Custom Groupings for the AE Assessment for @mattroumaya to implement and merge in to
fix-460cc: @gwu05 and @samussiah for comments if desired.
Test Notes/Sample Code
Untested 😱