Fix #711 - update unit tests for mapping functions #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samussiah
reviewed
Sep 8, 2022
| @@ -140,3 +140,8 @@ test_logical_parameters <- function(map_function, dfs) { | |||
| all(names(map_function(dfs = dfs, bReturnChecks = TRUE)) == c("df", "lChecks")) | |||
| ) | |||
| } | |||
|
|
|||
| subset_input_mapping <- function(input_spec, mapping_domain = "mapping_rawplus.yaml") { | |||
samussiah
reviewed
Sep 8, 2022
| @@ -0,0 +1,111 @@ | |||
|
|
|||
| # Create Unit Test Data --------------------------------------------------- | |||
| # this is a helper script that can be used to (mostly) programatically update unit test data | |||
There was a problem hiding this comment.
Awesome, this beats the heck out of updating those tribbles.
|
@mattroumaya, were #689 and #696 resolved in another PR? |
samussiah
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
This looks great @mattroumaya - love the programmatic test data! Just to confirm - did you intend to tag #689 and #696 here?
|
Thanks for the review @samussiah - and great catch on the linked PRs! Definitely meant to link them to the other open PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix #711
subset_input_mapping()to subset overall rawplus mapping{clindata}