8000 Update disposition mapping with discontinuation rather than completion. by samussiah · Pull Request #746 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update disposition mapping with discontinuation rather than completion. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

Update disposition mapping with discontinuation rather than completion. #746

merged 2 commits into from
Sep 20, 2022

Conversation

samussiah
Copy link
Contributor

Overview

Instead of identifying completion values it makes more sense to identify discontinuation values

Test Notes/Sample Code

Output should be unchanged.

Notes:

mattroumaya
mattroumaya approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor
@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @samussiah! 👍

@mattroumaya mattroumaya merged commit 03865b3 into dev Sep 20, 2022
@mattroumaya mattroumaya deleted the fix-692 branch September 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattroumaya mattroumaya mattroumaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samussiah @mattroumaya
0