8000 Fix 635 - Add country to grouping by mattroumaya · Pull Request #803 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 635 - Add country to grouping #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2022
Merged

Fix 635 - Add country to grouping #803

merged 5 commits into from
Oct 20, 2022

Conversation

mattroumaya
Copy link
Contributor

Overview

Fix #635

Added invid as placeholder for CustomGroup.

@mattroumaya
add country option
3913052
@mattroumaya
update tests
e3e46fc
@mattroumaya
ffwd
64bd000 
Merge remote-tracking branch 'origin/dev' into fix-635
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@mattroumaya mattroumaya self-assigned this Oct 12, 2022
samussiah
samussiah approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor
@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All assessments work with strGroup = 'Country' - looks good @mattroumaya!

@mattroumaya mattroumaya merged commit 9382f8c into dev Oct 20, 2022
@mattroumaya mattroumaya deleted the fix-635 branch October 20, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samussiah samussiah samussiah approved these changes

@jwildfire jwildfire Awaiting requested review from jwildfire

Assignees

@mattroumaya mattroumaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Hardcode CountryID in *_Assess() functions/mappings
2 participants
@mattroumaya @samussiah
0