8000 Fix 791 - Updated Assess() Unit Tests/Added Helper Functions by collleenmclaughlin · Pull Request #824 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 791 - Updated Assess() Unit Tests/Added Helper Functions #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Nov 1, 2022

Conversation

collleenmclaughlin
Copy link
Contributor

Fix #791

  • Drafted helper functions for Assess() testing (tests-assess_helpers.R)
  • Updated each of the 6 test_XX_Assess() codes to pull from new helper functions
  • Made sure testing incorporated missing required column(s) in dfInput and lMapping checks

@collleenmclaughlin collleenmclaughlin self-assigned this Oct 25, 2022
@collleenmclaughlin collleenmclaughlin added this to the v1.3.0 milestone Oct 25, 2022
@collleenmclaughlin collleenmclaughlin marked this pull request as ready for review October 25, 2022 19:55
Copy link
Contributor
@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Left some notes to check out and address, and should be ready to merge after that

R/tests-assess_helpers.R Outdated Show resolved Hide resolved
collleenmclaughlin and others added 13 commits October 27, 2022 23:19
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Copy link
Contributor
@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mattroumaya mattroumaya merged commit e94e291 into dev Nov 1, 2022
@mattroumaya mattroumaya deleted the fix-791 branch November 1, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 6626 div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjEwOTkxNzQ5OTAiLCJ0IjoxNzQ4OTMzOTE1fQ==--8d6d332914bd1919e14a6a85d7e1a44266be386130f923af61bf3a219c3ad30e" data-gid="PR_kwDOGo7Vjs5BhBRO" data-channel-event-name="sidebar_updated" data-url="/Gilead-BioStats/gsm/issues/824/show_partial?partial=issues%2Fsidebar" data-project-hovercards-enabled>
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC: Add unit tests for Assess functions
2 participants
0