-
Notifications
You must be signed in to change notification settings - Fork 14
Fix 791 - Updated Assess() Unit Tests/Added Helper Functions #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattroumaya
requested changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Left some notes to check out and address, and should be ready to merge after that
9998ab7
to
3890204
Compare
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
mattroumaya
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
<
6626
div id="partial-discussion-sidebar"
class="js-socket-channel js-updatable-content"
data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjEwOTkxNzQ5OTAiLCJ0IjoxNzQ4OTMzOTE1fQ==--8d6d332914bd1919e14a6a85d7e1a44266be386130f923af61bf3a219c3ad30e"
data-gid="PR_kwDOGo7Vjs5BhBRO"
data-channel-event-name="sidebar_updated"
data-url="/Gilead-BioStats/gsm/issues/824/show_partial?partial=issues%2Fsidebar"
data-project-hovercards-enabled>
Labels
None yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #791
Assess()
testing (tests-assess_helpers.R
)test_XX_Assess()
codes to pull from new helper functionsdfInput
andlMapping
checks