8000 update tests + workflows by mattroumaya · Pull Request #903 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update tests + workflows #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

update tests + workflows #903

merged 1 commit into from
Nov 30, 2022

Conversation

mattroumaya
Copy link
Contributor

Overview

  • Update unit tests
  • Update workflow YAML files

Notes:

  • Will add unit tests for assess functions
  • We should review mapping/joining logic in new map functions. It looks like there are issues when a SubjectID is or is not found in every dataset

Zhongkai-Wang
Zhongkai-Wang approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor
@Zhongkai-Wang Zhongkai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Matt. I'll merge it first and and add the final fixes in the original PR.

@Zhongkai-Wang Zhongkai-Wang merged commit f803b99 into fix-781 Nov 30, 2022
@samussiah samussiah deleted the fix-781-add-tests branch December 19, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhongkai-Wang Zhongkai-Wang Zhongkai-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattroumaya @Zhongkai-Wang
0