8000 Fix 837 report by mattroumaya · Pull Request #913 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 837 report #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 7, 2022
Merged

Fix 837 report #913

merged 12 commits into from
Dec 7, 2022

Conversation

mattroumaya
Copy link
Contributor
@mattroumaya mattroumaya commented Dec 3, 2022

Overview

Fix #837
Fix #904
Refactor report to add:

  • Summary table with flag directionality/indicators. Mimics heatmap in Gismo
  • Hide/show plots; show scatter plot by default
  • Aesthetic updates

Hopefully this meets needs for meetings with CROs next week, and we can keep updating as needed

@mattroumaya mattroumaya marked this pull request as ready for review December 7, 2022 01:24
study <- lAssessments[grep("kri", names(lAssessments))]


overview_table <- purrr::map(study, function(kri) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clinic of concise data manipulation @mattroumaya, love it!

Copy link
Contributor
@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated report looks great! I put the charts into tabs instead of hiding/showing them to save space but otherwise this looks super nice. Learn something new in dplyr every code review!

@samussiah samussiah merged commit 02a4a00 into dev Dec 7, 2022
@samussiah samussiah deleted the fix-837-report branch December 7, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants
0