8000 Fix 639; 1025 - fix barcharts + warning during rcmd check by mattroumaya · Pull Request #1026 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 639; 1025 - fix barcharts + warning during rcmd check #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix 639; 1025 - fix barcharts + warning during rcmd check #1026

merged 1 commit into from
Jan 26, 2023

Conversation

mattroumaya
Copy link
Contributor

Overview

Fix #639
Fix #1025

Notes:

  • All flagged values for IE and Consent appear as yellow bars since there is only one threshold. We might want to set extreme threshold values or come up with another method of indicating flagged vs. abnormal counts of IE/Consent issues.
  • For now, left as-is since {rbm-viz} handles bar charts in the same way.
  • Relevant issue here

@mattroumaya mattroumaya requested a review from samussiah January 18, 2023 20:42
mattroumaya
mattroumaya commented Jan 18, 2023
View reviewed changes
R/CheckSnapshotInputs.R
split(.$Table)
arrange(match(.data$Table, names(snapshot)))

gismo_input <- split(gismo_input, gismo_input$Table)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made because split(.data$Table) doesn't work, and kept being flagged during rcmd check.

@mattroumaya mattroumaya self-assigned this Jan 19, 2023
@samussiah samussiah merged commit c0cd7af into dev Jan 26, 2023
@samussiah samussiah deleted the fix-639 branch January 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samussiah samussiah samussiah approved these changes

Assignees

@mattroumaya mattroumaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugfix: Consent visualizations not supported for barChart Feature: Update Visualize_Score() aesthetics/logic
2 participants
@mattroumaya @samussiah
0