8000 Fix 1130 - add `Read_Mapping()` function by mattroumaya · Pull Request #1131 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 1130 - add Read_Mapping() function #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix 1130 - add Read_Mapping() function #1131

merged 2 commits into from
Apr 4, 2023

Conversation

mattroumaya
Copy link
Contributor

Overview

Fix #1130

Adds Read_Mapping() function that will read mappings from inst/mappings.

To test:

# return all mappings, except domain
m <- Read_Mapping()

# return rawplus only
rawplus <- Read_Mapping("rawplus")

# return rawplus and ctms
rawplus_and_ctms <- Read_Mapping(c("rawplus", "ctms"))

@mattroumaya
Copy link
Contributor Author

@samussiah @Zhongkai-Wang @jwildfire - going to add unit tests as well, but submitting this for review for whenever you have the chance.

samussiah
samussiah approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor
@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @mattroumaya!

@samussiah samussiah merged commit e2b26f5 into release-v1.6.0 Apr 4, 2023
@samussiah samussiah deleted the fix-1130 branch April 4, 2023 13:40
@mattroumaya mattroumaya mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samussiah samussiah samussiah approved these changes

@Zhongkai-Wang Zhongkai-Wang Awaiting requested review from Zhongkai-Wang

@jwildfire jwildfire Awaiting requested review from jwildfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattroumaya @samussiah
0