add fields to STUDY.yaml #1957
Merged
add fields to STUDY.yaml #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdz2101
reviewed
Nov 22, 2024
inst/workflow/1_mappings/STUDY.yaml
Outdated
| @@ -30,6 +30,24 @@ spec: | |||
| est_fpfv: | |||
| required: true | |||
| type: Date | |||
| est_lplv: | |||
| required: true | |||
There was a problem hiding this comment.
should these still be included? If the other PR is removing?
There was a problem hiding this comment.
depending on the order of merging, i'll take care of this. if it gets merged in before #1936, then we still need the required field
zdz2101
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add missing fields to STUDY.yaml
Test Notes/Sample Code
Connected Issues