8000 add namespacing capability by dpastoor · Pull Request #1988 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add namespacing capability #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 11, 2024
Merged

add namespacing capability #1988

merged 8 commits into from
Dec 11, 2024

Conversation

dpastoor
Copy link
Contributor
@dpastoor dpastoor commented Dec 11, 2024 •
edited
Loading

related to discussion in #1987

This will now allow workflows like:

steps:
  - output: lReport
    name: gsm.study.profile::Report_Study_Profile
    params:
      dfResults: Reporting_Results
      dfMetrics: Reporting_Metrics
      dfGroups: Reporting_Groups

to properly find the function calls they need.

jonthegeek
jonthegeek reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor
@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes, but not flagging it as "Request changes" because it's fine to merge this as-is. I'd just love it if we could genericize this a bit so we have one place to edit this, rather than a near-duplicate function in gsm.app.

R/util-func-namespace.R Outdated
Comment on lines 1 to 3
##' getFunctionIfNamespaced looks to see if a strFunction is namespaced and looks it up
##' allowing the do.call in run step to process correctly
##' this will either return a function, or the original string if not namespaced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we export this? Once we have it nailed down, I'll use it in gsm.app for plugin functions. I'd genericize the name a little, too, since this function will parse strFunction whether or not it's namespaced.

tests/testthat/test-RunStep.R

result <- RunStep(lStep, lData, lMeta)
expect_equal(result, head(Theoph))
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for a non-namespaced function to make sure it doesn't ever break anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test added!

lauramaxwell
lauramaxwell approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor
@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added a few edits to _pkgdown.yml and NEWS.md to prep for the v2.2.0 RC

@dpastoor dpastoor merged commit 606e19a into v2.2.0-rc Dec 11, 2024
@dpastoor dpastoor deleted the namespacing-1987 branch December 11, 2024 16:10
@jonthegeek jonthegeek mentioned this pull request Dec 11, 2024
Closed
@lauramaxwell lauramaxwell mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramaxwell lauramaxwell lauramaxwell approved these changes

@jonthegeek jonthegeek jonthegeek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpastoor @lauramaxwell @jonthegeek
0