Review package dependencies #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthegeek
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good!
One ~style comment: I prefer to only @importFrom (or @import) things in these categories:
- Things that are used all over the place (eg
cli_abort). - Things to allow you to put a package in Imports without R CMD Check freaking out (eg sometimes that's necessary for
glueorlifecycle). - Things that are difficult to namespace (
%||%fromrlang, etc).
For everything else, just pkg::function when they're used. That way you don't keep @importFroming after the function is no longer used.
Not a necessary change, just my $0.02!
|
Oops! Looks like the specific method we use might come from {broom} specifically. |
Yep- just saw those test failures. looks like i'll have to revert it to using broom. i'll get to that after scrum. thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused dependencies for the gsm package.
Closes #1979