8000 Remove hard dependency on `InvestigatorLastName` and incorporate tweaks to `gsm.viz`. by samussiah · Pull Request #2038 · Gilead-BioStats/gsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove hard dependency on InvestigatorLastName and incorporate tweaks to gsm.viz. #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

samussiah
Copy link
Contributor

Overview

  • Positive thresholds were displaying incorrectly because I forgot to copy over the latest tweaks.
  • An absent InvestigatorLastName was bombing the reports.

Test Notes/Sample Code

Connected Issues

@samussiah samussiah requested a review from lauramaxwell March 5, 2025 01:29
Copy link
Contributor
@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! looks good to me

@lauramaxwell lauramaxwell merged commit e1b2878 into dev Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: MakeMetricTable has a hard dependency on dfGroups$InvestigatorLastName.
2 participants
0