8000 Use more strict context ID for images during preview by SamyPesse · Pull Request #3261 · GitbookIO/gitbook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use more strict context ID for images during preview #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000 Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Use more strict context ID for images during preview #3261

merged 1 commit into from
May 23, 2025

Conversation

SamyPesse
Copy link
Member

No description provided.

@linear Linear
Copy link
linear bot commented May 23, 2025

RND-7183 Images fail to load in preview v2 because of invalid signatures

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: 5e24582

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://f43a8ad6.gitbook-open.pages.dev ✅
PR https://pr3261.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-2xmdtyrfb-gitbook.vercel.app ✅
Cloudflare https://e10394ec-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://f43a8ad6.gitbook-open.pages.dev/gitbook.com/docs https://gitbook-v2-2xmdtyrfb-gitbook.vercel.app/url/gitbook.com/docs https://e10394ec-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E https://f43a8ad6.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-2xmdtyrfb-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://e10394ec-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link
argos-ci bot commented May 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - May 23, 2025, 9:55 AM
customers-v2 (Inspect) 👍 Changes approved 79 changed May 23, 2025, 10:48 AM
default (Inspect) ✅ No changes detected - May 23, 2025, 9:56 AM
v2-cloudflare (Inspect) ✅ No changes detected - May 23, 2025, 9:56 AM
v2-vercel (Inspect) ✅ No changes detected - May 23, 2025, 9:56 AM

@SamyPesse SamyPesse marked this pull request as ready for review May 23, 2025 10:44
@SamyPesse SamyPesse changed the title Fix image resizing during site preview Use more strict context ID for images during preview May 23, 2025
@SamyPesse SamyPesse merged commit 6f8ecd6 into main May 23, 2025
21 checks passed
@SamyPesse SamyPesse deleted the samy/rnd-7183-images-fail-to-load-in-preview-v2-because-of-invalid branch May 23, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorelli spastorelli spastorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamyPesse @spastorelli
0