Deduplicate path parameters from OpenAPI spec #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4b150e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR deduplicates duplicate OpenAPI path parameters by filtering out duplicates based on their name and location.
- Replace the direct usage of operation parameters with a deduplicated list.
- Introduce a helper function (deduplicateParameters) to encapsulate the deduplication logic.
- Update the changeset file to indicate the deduplication improvement.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-openapi/src/OpenAPISpec.tsx | Replaces the parameter list with a deduplicated one using a helper function and adds the deduplication function. |
| .changeset/violet-schools-care.md | Adds a changeset entry to document the deduplication change. |
Comments suppressed due to low confidence (1)
packages/react-openapi/src/OpenAPISpec.tsx:121
- Consider adding unit tests to confirm that the deduplication logic works as expected for various scenarios, including edge cases where parameters only differ in case or other properties.
function deduplicateParameters(parameters: OpenAPI.Parameters): OpenAPI.Parameters {
gregberge
approved these changes
May 26, 2025
|
Summary of the deployments: Version 1
Version 2
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
c4b150e to
450f97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.