8000 Remove estimated matching from "donate" page by maryjaf · Pull Request #5160 · Giveth/giveth-dapps-v2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove estimated matching from "donate" page #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Remove estimated matching from "donate" page #5160

merged 1 commit into from
Jul 9, 2025
+1 −20

Conversation

maryjaf
Copy link
Collaborator
@maryjaf maryjaf commented Jul 8, 2025 •
edited by coderabbitai bot
Loading

Remove estimated matching from "donate" page during QF rounds #5147

Summary by CodeRabbit

  • Refactor
    • Removed the display of estimated matching amounts from the donation project description page.

@maryjaf maryjaf requested review from kkatusic and RamRamez July 8, 2025 12:47
@vercel Vercel
Copy link
vercel bot commented Jul 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 0:53am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 8, 2025

Walkthrough

The changes remove the import and usage of the calculateTotalEstimatedMatching function in the DonatePageProjectDescription component. The JSX block displaying the estimated matching amount with its styled component is deleted, leaving only the project description without estimated matching information.

Changes

File(s) Change Summary
src/components/views/donate/DonatePageProjectDescription.tsx Removed import and usage of calculateTotalEstimatedMatching; deleted JSX block for matching display.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant DonatePageProjectDescription
  Note over DonatePageProjectDescription: Previous Flow
  User->>DonatePageProjectDescription: View project description
  DonatePageProjectDescription->>calculateTotalEstimatedMatching: (calculate estimated match)
  DonatePageProjectDescription-->>User: Display project description + estimated matching

  Note over DonatePageProjectDescription: Updated Flow
  User->>DonatePageProjectDescription: View project description
  DonatePageProjectDescription-->>User: Display project description only
Loading

Possibly related PRs

Suggested reviewers

  • CarlosQ96
  • kkatusic

Poem

The matching math has hopped away,
No more numbers on display—
Just a project, pure and bright,
Donation page feels clean and light.
With every hop, the code grows neat,
A bunny’s work is now complete! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f3cc41 and 005a5ff.

📒 Files selected for processing (1)
  • src/components/views/donate/DonatePageProjectDescription.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (2)
src/components/views/donate/DonatePageProjectDescription.tsx (2)

27-27: LGTM: Import correctly updated.

The import has been appropriately updated to remove calculateTotalEstimatedMatching while retaining getActiveRound which is still used in the component.

27-27: Successfully removed estimated matching feature.

The change successfully removes the estimated matching feature from the donate page as intended in the PR objectives. The import cleanup is correct, and the component will no longer display estimated matching information during QF rounds.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

RamRamez
RamRamez approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator
@RamRamez RamRamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maryjaf

@maryjaf maryjaf merged commit 9c44978 into develop Jul 9, 2025
4 checks passed
@maryjaf maryjaf deleted the Remove-estimated-matching-from-"donate"-page branch July 9, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamRamez RamRamez RamRamez approved these changes

@kkatusic kkatusic Awaiting requested review from kkatusic

Assignees
No one assigned
Labels
None yet
Projects
Giveth Development
Status: QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryjaf @RamRamez
0