8000 In the check_uri_trailing_slash, check if the request method is GET by amieiro · Pull Request #1879 · GlotPress/GlotPress · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

In the check_uri_trailing_slash, check if the request method is GET #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

In the check_uri_trailing_slash, check if the request method is GET #1879

wants to merge 2 commits into from

Conversation

amieiro
Copy link
Member
@amieiro amieiro commented Dec 5, 2024

Problem

The problem this PR fixes is described in #1878. We are making a redirection in some HTTP methods, in the check_uri_trailing_slash method, if the URI doesn't have a trailing slash, and it breaks the functionality in the POST methods, because it makes a GET redirection.

Solution

This PR checks if the method redirected in the check_uri_trailing_slash method is the GET method.

Fixes #1878.

@amieiro amieiro assigned amieiro and unassigned amieiro Dec 5, 2024
@amieiro amieiro requested review from akirk and trymebytes December 5, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk Awaiting requested review from akirk

@trymebytes trymebytes Awaiting requested review from trymebytes

At least 1 approving review is required to merge this pull request.

Assignees

@amieiro amieiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the trailing slash to the URI only when the request method is GET
1 participant
@amieiro
0