Sync with the main repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for specifying kubernetes namespace This change will allow users to submit jobs to a specific namespace in a k8s cluster rather than having them all run in the default namespace. * Updated optional parameter to OptionalParameter type
The `python_version` conditional was added fairly recently (<2 years). We've run into a few cases where it would be very convenient for luigi to support older setuptools (e.g. managed environments where it may be difficult or not possible to upgrade).
* Require minimum botocore version with s3transfer>=0.2.0 compatibility * Replace min botocore version with locked s3transfer version
The context manager FileSystemTarget.temporary_path() rolled its own manager, it was overcomplicated so i rewrote using contextlib.
Users will now see a big warning, see the docs update for how to resolve it.
See docs for usage.
See docs for usage.
* Add pai task to support open pai * Support read config to get token and check job status * Correct the open pai url * Using mock response to test pai task; make required property abstract * fixed the code format; make it works with python3 * Add __slots__ back for json dump * Modified according to the comments; 1) correct/add more doc strings. 2) raise exception when 404 3) use global logger directly. 4) change expiration to integer * Cleanup according to comments; refine unittest * Limit reqeust to 2.20 for requests lib issue 4830 * Remove duplicated test job class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Have you tested this? If so, how?