This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Adjust date format to match filter format. #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though I think the message is still potentially confusing - "MMM" means the three-letter english month name abbreviation? |
|
Correct; the issue in ui-grid is with "MMM dd yyyy" always being the date format for filter strings, ie: Dec 03 2015. |
jmuharsky
added a commit
that referenced
this pull request
Dec 8, 2015
Adjust date format to match filter format.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to workaround an issue/lack of clarity on changing the date format for filter textboxes in UI grid:
angular-ui/ui-grid#4806