Fix perftests CMake target being empty: https://github.com/GridTools/gridtools/issues/1551 #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, this is jenkins continuous integration... |
havogt
requested changes
Jul 27, 2022
tests/regression/CMakeLists.txt
Outdated
| "${CMAKE_BINARY_DIR}/perftests_dummy.cpp" | ||
| "// This file is needed in some cases because CMake targets must have at least one .cpp source." | ||
| ) | ||
| target_sources(perftests PRIVATE "${CMAKE_BINARY_DIR}/perftests_dummy.cpp") |
There was a problem hiding this comment.
Suggested change
| target_sources(perftests PRIVATE "${CMAKE_BINARY_DIR}/perftests_dummy.cpp") | |
| target_sources(perftests PRIVATE "${CMAKE_CURRENT_BINARY_DIR}/perftests_dummy.cpp") |
Co-authored-by: Hannes Vogt <hannes@havogt.de>
havogt
approved these changes
Jul 27, 2022
|
launch jenkins |
|
add to whitelist |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch perftest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1551. You cannot make a CMake target with no sources and no linker input, so this adds a dummy source file to the perftests target for when there are no linker inputs either.