8000 Improved Data Layout for Neighbor Tables by fthaler · Pull Request #1782 · GridTools/gridtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved Data Layout for Neighbor Tables #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

fthaler
Copy link
Contributor
@fthaler fthaler commented Jun 11, 2024

Uses unit stride in location dimension (SoA layout) instead of array-of-tuple (AoS layout) in the fn nabla tests.

@fthaler
Copy link
Contributor Author
fthaler commented Jun 11, 2024

launch perftest

@gridtoolsjenkins
Copy link
Collaborator

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

@fthaler
Copy link
Contributor Author
fthaler commented Jun 11, 2024

launch jenkins

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch perftest

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch jenkins

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch perftest

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch jenkins

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch perftest

@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch jenkins

1 similar comment
@fthaler
Copy link
Contributor Author
fthaler commented Jun 12, 2024

launch jenkins

@fthaler fthaler requested a review from havogt June 12, 2024 09:44
Copy link
Contributor
@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update references again.

@havogt
Copy link
Contributor
havogt commented Jun 18, 2024

launch perftests

@fthaler
Copy link
Contributor Author
fthaler commented Jun 18, 2024

launch jenkins

@fthaler
Copy link
Contributor Author
fthaler commented Jun 18, 2024

launch perftest

@havogt
Copy link
Contributor
havogt commented Jun 18, 2024

Was there any difference in the end? Can you add a comment in the PR description how performance changed.

@fthaler fthaler merged commit 0f9b8bb into GridTools:master Jun 18, 2024
68 checks passed
@fthaler fthaler deleted the better-nbtable-layout branch June 18, 2024 08:01
havogt pushed a commit that referenced this pull request Jun 18, 2024
Use unit stride in location dimension (SoA layout) instead of
array-of-tuple (AoS layout) in the fn nabla tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0