8000 build[dace][next]: Updated DaCe by philip-paul-mueller · Pull Request #2064 · GridTools/gt4py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build[dace][next]: Updated DaCe #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

philip-paul-mueller
Copy link
Contributor
@philip-paul-mueller philip-paul-mueller commented Jun 5, 2025

Updates the DaCe dependency.

Note:
This PR includes blocked_copy_to_map PR, which makes the silent transformation of Maps inside the dace code generator a hard error.
This is the actual correct behaviour at least in GT4Py as this leads to performance degradation and even launch errors.

There is one PR missing, that is not yet opened in DaCe.
However, that PR is not needed by GT4Py, thus we can technically merge it.
@edopao edopao changed the title build[dace][nex]: Updated DaCe build[dace][next]: Updated DaCe Jun 5, 2025
edopao
edopao previously approved these changes Jun 5, 2025
Now the generation of Maps in the code generator in GPU mode has become a hard error.
This makes it imperative that we only merge the PR once we have CI back and have made sure that all tests, also the one in ICON4Py have passed!
@philip-paul-mueller philip-paul-mueller changed the title build[dace][next]: Updated DaCe DO NOT MERGE build[dace][next]: Updated DaCe Jun 6, 2025
@edopao edopao dismissed their stale review June 6, 2025 11:34

Requires more testing, because of GridTools/dace#5

@philip-paul-mueller philip-paul-mueller changed the title DO NOT MERGE build[dace][next]: Updated DaCe build[dace][next]: Updated DaCe Jun 10, 2025
@philip-paul-mueller philip-paul-mueller merged commit e3d0790 into GridTools:main Jun 10, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0