fix[next][dace]: Do not apply map_promoter on symbolic range #2071
+147
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we have to refine the approach a little bit but we are close.
If you need a discussion or if you need help in merging, as we have modified the transformation in PR#2063 please drop me a message.
src/gt4py/next/program_processors/runners/dace/transformations/map_promoter.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/transformations/map_promoter.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/transformations/map_promoter.py
Outdated
Show resolved
Hide resolved
...am_processor_tests/runners_tests/dace_tests/transformation_tests/test_serial_map_promoter.py
Show resolved
Hide resolved
philip-paul-mueller
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 1d temporary is consumed by different 2d maps, with symbolic range, we can promote the 1d producer map to a 2d map only if the range of the new dimension is known to be not empty. The issue found in icon4py (stencil
39_to_40, without constant substitution) was that the temporary was no longer produced, after applying MapPromotion, because the new dimension was empty. The other consumer maps, that actually needed the temporary data, found uninitialized data (it happened to be zeros).