[pull] master from ppy:master #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a32bae2.
…sages You'll probably wisely ask "what is this title? isn't that the tail wagging the dog?" It is. `PassThroughInputManager` usage in `RulesetInputManager` sucks. It should not exist. #6579 broke game-side osu! touch input mapping (see test failures at https://github.com/ppy/osu/actions/runs/15438536705/job/43453184186) because the touch input mapping wants to do its bespoke mouse position logic on top of `PassThroughInputManager`. It is my firm belief that `RulesetInputManager` should stop using `PassThroughInputManager` and instead roll its own bespoke logic. But I am not going to do that here, because I want to put a framework release out now rather than in a week, so this attempts to roll out the fix in #6579 in a slightly different (read: uglier) way so that it does not break the delicate game-side usages. If that is not an acceptable outcome, the only other thing I can offer is a revert. The last time we had this sort of situation is `DecoupleableInterpolatingFramedClock` which was also a situation where the tail wagged the dog for so long and in such inscrutable manner that eventually it got deleted and rewritten using other classes. Which took weeks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )