[MAINT] Rework queuing functionality around multiplexer and snd/rcv queues #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to emulate blocking connect
…or in-muxer list). Added in-muxer socket list. Fixed tests to close all sockets. Tests socket complete wipeout.
| @@ -11255,7 +11096,7 @@ | |||
| // XXX Make this function return EConnectStatus enum type (extend if needed), | |||
| // and this will be directly passed to the caller. | |||
|
|
|||
| // [[using locked(m_pRcvQueue->m_LSLock)]]; | |||
| // [[using locked(m_RcvQueue.m_LSLock)]]; | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
| /// Remove UDT instance from the list. | ||
| /// @param [in] u pointer to the UDT instance | ||
| void remove(const CUDT* u);// EXCLUDES(m_ListLock); | ||
| void remove(const CUDT* u); | ||
| void remove(CSNode* u);// EXCLUDES(m_ListLock); |
Check notice
Code scanning / CodeQL
Commented-out code Note
added 11 commits
June 16, 2025 12:22
Comment on lines
+669
to
+679
| /* | ||
| * XXX TEMPTING, but this breaks the rule that a socket moved to | ||
| * the dead region may still send out packets, if there is any left. | ||
|
|
||
| CUDTUnited::SocketKeeper sk (CUDT::uglobal(), u->id()); | ||
| if (!sk.socket) | ||
| { | ||
| HLOGC(qslog.Debug, log << "Socket to be processed was deleted in the meantime, not packing"); | ||
| continue; | ||
| } | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
srtcore/queue.cpp
Outdated
Comment on lines
1071
to
1080
| /* | ||
| CUDTUnited::SocketKeeper sk (CUDT::uglobal(), i->id); | ||
| if (!sk.socket) | ||
| { | ||
| // Socket deleted already, so stop this and proceed to the next loop. | ||
| LOGC(cnlog.Error, log << "updateConnStatus: IPE: socket @" << i->id << " already closed, proceed to only removal from lists"); | ||
| toRemove.push_back(*i); | ||
| continue; | ||
| } | ||
|
|
||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this changeset is to rework the queuing of sent and received packets to allow more flexible send scheduling.
m_SendBlockCondCV. This CV has been used because it's not used at the time when the connection is not yet established and it corresponds with the rule that the epoll OUT event is used as a signal for connection readiness.srt_sendmsg2call as the sending time.Further changes embrace: update the tests and testing apps by fixing some problems connected to too early socket closing.