Yaesu newcat backend fixes for multiple rigs #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of the filter definitions and try to unify and fix any bugs. Add roofing filter support for FT-950 and FT-2000.
…low setting DSP filter width correctly. Handle setting of roofing filter and narrow mode for AM/FM modes.
…nds. Implement Yaesu break-in delay level correctly using these conversion routines.
…it regardless of documentation
This was referenced Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes a large set of fixes for many rig funcs and levels in the Yaesu newcat backend.
I've tested these fixes on FTDX 5000 and FT-991, but I've gone through many (almost all?) newcat Yaesu rig CAT manuals while fixing each command/feature, so that I've attempted to cover every possible rig. The rigs include: FT-450, FT-950, FT-2000, FT-891, FT-991, FTDX 1200, FTDX 3000, FTDX 5000, FTDX 9000 and FTDX101. I haven't gone through every single command implemented, but mainly fixing things where I've seen issues with testing or where code has been clearly incomplete/buggy.
The most important changes are:
Add complete set of filter widths for all of the above rigs.
Fix break-in delay level for all Yaesu rigs: convert 1/10th dots to milliseconds correctly via generic conversion routines. Setting/getting break-in level includes checking current key speed for the conversion. Fixes Yaesu break-in delay scale #432.
Fixed scales for many rig levels where differences between rigs weren't covered correctly.
Added ANTI VOX commands for all of the mentioned rigs
Add further fixes for handling the ambiguous
?response that can indicate either the rig being busy (and needs to be retried) or that the command was rejected by the rig (and retry won't fix it). The retry mechanism was removed from newcat_get_cmd, as it seems it's never needed and the other interpretation of the?response is correct. I added more details of this issue in the code comments. Fixes Yaesu error response?interpretation #434.Fixed and added missing definitions in capabilities of above rigs (e.g. modes, filters, preamps, attenuator settings, antennas...). All of the changes are based on documentation found in CAT / user manuals of the rigs.