10000 Icom extcmds fixes by mikaelnousiainen · Pull Request #381 · Hamlib/Hamlib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Icom extcmds fixes #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2020
Merged

Icom extcmds fixes #381

merged 3 commits into from
Sep 16, 2020

Conversation

mikaelnousiainen
Copy link
Contributor
@mikaelnousiainen mikaelnousiainen commented Sep 16, 2020 •
edited
Loading

This PR makes the following changes regarding Icom extcmds:

  • Fix matching of extcmds for ext tokens in (get|set)_ext_(level|func|parm)
  • Fix definitions of Icom DIGI_SEL / DIGI_SEL_LEVEL / DRIVE_GAIN and move them from parms to levels/func
  • Fix additional bugs in icom_set_cmd handling
  • Migrate custom level functions to extcmd definitions in most Icom rigs
  • get_func and set_func will first check rig extcmds for handling the function (like levels and parms already do)

There are also the following improvements in the PR:

  • Add example extfunc to dummy rig
  • Print out extfuncs in caps dump

The changes to having extcmds handle the previously defined custom parms for IC-7300 have been tested on a real rig.
Additionally, DRIVE_GAIN has been tested on IC-7600.

@mikaelnousiainen
Fix issues with Icom extcmds definitions, some ext_tokens missing. Re…
23971f8 
…factor custom level implementations to use extcmds definitions. Print out extfuncs in caps dump.
@mikaelnousiainen
Merge branch 'master' into icom-extcmds-fixes-1
7c4f0d0
@mikaelnousiainen
Fix errors in Icom extcmd definitions and handling. Migrate more comm…
499d17c 
…ands on Icom rigs to use extcmds. Add extfuncs to dummy rig for testing.
@mdblack98 mdblack98 linked an issue Sep 16, 2020 that may be closed by this pull request
IC-7300 some levels wrong #373
Closed
@mdblack98 mdblack98 merged commit 4e22e0d into Hamlib:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IC-7300 some levels wrong
2 participants
@mikaelnousiainen @mdblack98
0