-
-
Notifications
You must be signed in to change notification settings - Fork 246
feat: DK spec setting to prevent Death and Decay while moving #4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DK spec setting to prevent Death and Decay while moving #4716
Conversation
If DnD isn't active (on the ground), and you have this on, it just won't be recommended if you're moving around the boss to reposition or dodge a mechanic, in a situation where you would definitely want to cast it. If it was expiring soon and you didn't know and were moving around the boss for a mechanic, it would be a surprise in the queue when you stopped, but you should have known 3 globals ago. Just introduces a new problem to solve the old one. I would suggest one of these:
Thoughts? Long term this is the kinda thing we can hook up to the status bar once it's implemented which I think would be neat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would want to present this in the inverse, maybe Death and Decay: No Movement
.
The description would need to clarify the downsides. In M+, there's a lot of movement and a fair chance you're strafing and would benefit from being told its time for DnD. Something like:
If enabled, Death and Decay will not be recommended when you are moving.
This feature may help you to avoid dropping a Death and Decay AOE when you may move out of it, but it could also cause you to delay for a significant amount of time while moving.
I will probably go with this approach. Especially with the grace period, this will probably work best in practice. If you are genuinely running around but still need to refresh DnD, you actually don't want to because the subsequent recommendations in the queue rely on DnD being down. |
This is a bit of a UI/UX issue, but I'm generally against toggling something on to mean that something else is turned off. I tried to just have a sensible default where nothing is changed. If you want though, I will reverse the meaning of the toggle, but it does get really awkward when you ask someone, "did you set DnD to not be recommended while moving" and they say "yes". |
Looking at this some more, I don't think this approach will work. The scenario that I'm guessing is in the mind of the player that requested this is the boss is being kited, e.g., 2nd boss in Priory, or last boss in Ner'ubar Palace, that you wouldn't want DnD to be suggested, but perhaps you still want to do damage even in that case. Perhaps this scenario is a bit too niche? I see that we have a Maybe it's better just to drop this feature altogether? |
IDK, this seems like something useful (and likely desired) by a fair number of folks, but I worry a little bit that they won't understand the advantages/disadvantages if not spelled out in a clear and accessible way. |
I wonder if perhaps the This might better model the way movement actually is in both dungeons and raids. |
Good idea. |
No description provided.