Fix the Snapshot info on Roll the bones #4835
Conversation
Fix the Snapshot info on Roll the bones. Old snapshot was not labling "normal", "shorter", "longer" appropriately
|
For the change here, are we only concerned about the snapshot text output or are you seeing issues with what the addon would reroll away? If it's just the snapshot text that seems off, this is fine.
deep breath Work time is how much actual time the addon took to calculate recommendations. That work is divided in pieces so it doesn't spike and impact your frame rate (too significantly). So, in the worst case, it took the addon 32ms over 5 frames (6.4 ms/frame). If your frame rate is locked to 60 FPS, that's 16.667ms per frame for the game engine, the base UI, and all addons to complete their work without delaying the next frame. Peak time is actual time between when the addon started generating a set of recommendations and when it finished. This peak time does not necessarily correspond to the peak work, above. If the addon does 6ms of work per "busy" frame and there's 16.667ms per frame and (let's say) this set took 18ms, then we'd expect the work time to be 18ms and the actual time to complete would be 16.667 (frame 1) + 16.667 (frame 2) + somewhere between 6 and 16.667 (frame 3) or ~40ms to 50ms. At some point, 737ms passed between the time the addon started calculating and finished calculating its recommendations. Since the peak work and the peak time really don't correspond, it suggests either (1) the game engine pooped itself and had one of those post-11.1 hiccups or (2) another addon ate a bunch of CPU time in the space between this addon's work. |
|
It is purely cosmetic for the snapshot output. I have not seen issues in rerolling |
|
Thanks for the clarification about performance info |
Fix the Snapshot info on Roll the bones.
Old snapshot was not labling "normal", "shorter", "longer" appropriately
Example of the current snapshot:
https://pastebin.com/PsSbxfTb
As a sidenote:
What is that peak time?)