Hpal Model Accuracy #4866

syrifgit · 2025-05-15T01:29:12Z

Various Improvements to HPal model

Support blessing_of_anshe
- It was in the ret file, but they have different spellIDs for each spec
Fix avenging_wrath/crusader duration
awakening
- Fix max stacks
- Change handler to reflect correct max stack count
- Handler was incorrectly called in many places, which is now fixed
spend and runHandler hooks
- Tested and separated interactions which work with free holy power spenders, moved into runHandler
- Those that do not work with free spenders remain in the spend hook
- Some interactions were moved to these 2 hooks instead of being repeatedly defined within ability registrations
InfusionOfLight
- Reduce duplicate code by turning into a function, called by 2 abilities
crusader_strike
- wowhead tooltip isn't correct, it says 6 seconds but it appears to actually be 7 ingame
holy_shock
- Cooldown definition was very wrong. Fixes cooldown.holy_shock.charges always return 0 #4858
- Removed the unnecessary looping for the triple-casts, only 2 interactions need to reference it
judgment
- Cooldown definition was wrong
- Added mana cost reduction via talent
- Handler simplified (infusion of light)
- Added the auto-consecrate effect from talent

TheWarWithin/PaladinHoly.lua

Hekili

Couple of questions.

Hpal Improvements

0ff1898

syrifgit mentioned this pull request May 15, 2025

cooldown.holy_shock.charges always return 0 #4858

Closed

5 tasks

syrifgit added the ✅ Bug Fix Fixes a known bug or open issue label May 15, 2025