8000 protobuf 30.1 by BrewTestBot · Pull Request #210860 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

protobuf 30.1 #210860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

protobuf 30.1 #210860

wants to merge 27 commits into from

Conversation

BrewTestBot
Copy link
Member
@BrewTestBot BrewTestBot commented Mar 13, 2025 •
edited by cho-m
Loading

Created by brew bump

Created with brew bump-formula-pr.

TODO, split out Protobuf 29 downgrades

Blocked by Linux formulae that fail with Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size)

  • ola (only has direct dependency on protobuf@29) 
      ==> /home/linuxbrew/.linuxbrew/Cellar/ola/0.10.9_6/bin/ola_plugin_state -h
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741969269.420588  197450 descriptor_database.cc:550] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1741969269.420711  197450 descriptor.cc:2248] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  • openvino (has multiple dependencies on protobuf from direct and onnx) 
      ==> /tmp/openvino-test-20250314-60982-58fy40/openvino_frontends_test
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741966434.971057   61124 descriptor_database.cc:635] File already exists in database: 
  F0000 00:00:1741966434.972610   61124 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  • opencv (has multiple dependencies on protobuf from direct, openvino and onnx) 
      ==> python3.13 -c 'import cv2; print(cv2.__version__)'
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741975112.242688  244594 descriptor_database.cc:552] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1741975112.242769  244594 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  • or-tools (only has direct dependency on protobuf) 
      ==> ./simple_lp_program
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741976060.120565  258906 descriptor_database.cc:635] File already exists in database: 
  F0000 00:00:1741976060.120701  258906 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  • pytorch 
      WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741988015.358958  434809 descriptor_database.cc:552] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1741988015.359246  434809 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***

Backports:

Workarounds:

  • openvino - add workaround to allow newer Protobuf. Need to report upstream

Follow ups to report upstream:

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Mar 13, 2025
scpeters
scpeters reviewed Mar 14, 2025
View reviewed changes
@cho-m cho-m marked this pull request as draft March 14, 2025 02:45
@cho-m cho-m added in progress Stale bot should stay away CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Mar 14, 2025
@cho-m cho-m force-pushed the bump-protobuf-30.1 branch from c23fa1c to bcb61a0 Compare March 14, 2025 05:38
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 14, 2025
@cho-m cho-m changed the title protobuf 30.1 protobuf 30.1, protobuf@29 29.3 (new formula) Mar 14, 2025
@cho-m cho-m added CI-linux-self-hosted Build on Linux self-hosted runner no long build conflict Do not allow merging other pull requests when files conflict with this one labels Mar 14, 2025
@cho-m cho-m force-pushed the bump-protobuf-30.1 branch from bcb61a0 to f5611b8 Compare March 14, 2025 14:00
@cho-m cho-m marked this pull request as ready for review March 14, 2025 14:00
@cho-m
Copy link
Member
cho-m commented Mar 14, 2025 •
edited
Loading

Linux is going to be the blocker as we've been hitting some error for a while now (e.g. OpenCV PRs like #208693) which is showing up here:

  ==> /home/linuxbrew/.linuxbrew/Cellar/ola/0.10.9_6/bin/ola_plugin_state -h
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741969269.420588  197450 descriptor_database.cc:550] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1741969269.420711  197450 descriptor.cc:2248] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***

  ==> /tmp/openvino-test-20250314-60982-58fy40/openvino_frontends_test
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1741966434.971057   61124 descriptor_database.cc:635] File already exists in database: 
  F0000 00:00:1741966434.972610   61124 descriptor.cc:2265] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size)

@cho-m cho-m added test failure CI fails while running the test-do block linux Linux is specifically affected blocked help wanted Task(s) needing PRs from the community or maintainers and removed no long build conflict Do not allow merging other pull requests when files conflict with this one labels Mar 14, 2025
This was referenced Mar 14, 2025
Merged
Merged
@cho-m cho-m marked this pull request as draft March 15, 2025 14:14
@cho-m cho-m changed the title protobuf 30.1, protobuf@29 29.3 (new formula) protobuf 30.1 Mar 15, 2025
@cho-m cho-m force-pushed the bump-protobuf-30.1 branch from f5611b8 to 41940fa Compare March 16, 2025 03:51
@scpeters scpeters mentioned this pull request Mar 16, 2025
Closed
12 tasks
@cho-m cho-m added the brew Issue may be Homebrew/brew related label Mar 27, 2025
@bobcallaway bobcallaway mentioned this pull request Apr 10, 2025
Merged
@daeho-ro daeho-ro mentioned this pull request Apr 15, 2025
Closed
6 tasks
@botantony
Copy link
Contributor

Protobuf 30.2 is available

@chenrui333 chenrui333 force-pushed the bump-protobuf-30.1 branch from 41940fa to cb8bbce Compare June 22, 2025 00:27
@github-actions github-actions bot added the alias label Jun 22, 2025
@chenrui333
Copy link
Member

previously, https://github.com/Homebrew/homebrew-core/commits/41940fa56d1f7df7a425596868fc935d55013d6b

@chenrui333 chenrui333 force-pushed the bump-protobuf-30.1 branch from cb8bbce to b7a92e3 Compare June 22, 2025 17:46
@chenrui333 chenrui333 added the CI-no-bottle-cache Disable bottle cache label Jun 22, 2025
@chenrui333 chenrui333 force-pushed the bump-protobuf-30.1 branch from b7a92e3 to 1e13cec Compare June 23, 2025 00:50
chenrui333 and others added 11 commits June 22, 2025 20:53
@chenrui333 chenrui333 force-pushed the bump-protobuf-30.1 branch from 1e13cec to 7acdf47 Compare June 23, 2025 00:53
@chenrui333 chenrui333 mentioned this pull request Jun 23, 2025
Merged
@achernya
Copy link

I believe the PR #227847 is unnecessary -- I tried to run the failing test against protobuf 30.1 and it passes. Looking at the test, it does something silly: it looks if runtime was more than 1 wallclock second, and if so, fails. I think the runner was just busy. I'll make a note to fix this test, but in the meantime, please retry with protobuf 30.1 for mosh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
alias automerge-skip `brew pr-automerge` will skip this pull request blocked brew Issue may be Homebrew/brew related bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away linux Linux is specifically affected long build Set a long timeout for formula testing test failure CI fails while running the test-do block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BrewTestBot @cho-m @botantony @yordis @chenrui333 @achernya @scpeters
0