Issues/issue 120 - Failed Checkout Returns to Cart #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2018 14:26
… as there will never be a cart because the order has already been placed
WillStrohl
reviewed
Apr 12, 2018
| @@ -11,6 +11,7 @@ | |||
| *.sln.docstates | |||
| *.local.sln | |||
| *.GhostDoc.xml | |||
| ._*.* | |||
|
Posh git adds a ._hotcakes.sln file on my system. If needed I can remove that item from the gitignore file.
… On Apr 12, 2018, at 4:41 PM, Will Strohl ***@***.***> wrote:
@hismightiness commented on this pull request.
Please see my comment about the gitignore update.
In .gitignore:
> @@ -11,6 +11,7 @@
*.sln.docstates
*.local.sln
*.GhostDoc.xml
+._*.*
What is this update for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
No need to remove it. I just wanted to know what it was for. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the PaymentError action will always be called after the order has been created and the cart cookie has been cleared I have removed the CurrentCart check since it will always return null.